This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 09/40] Rename make_symbol_completion_list_fn -> symbol_completer


On 06/02/2017 05:22 AM, Pedro Alves wrote:
> "make_symbol_completion_list_fn" is odly named when you look at a list
> of "standard" completers, like the Python/Guild completer lists
> adjusted by this patch.  Rename / move it to completers.h/c, for
> consistency.

Oh, man, I totally agree. make_symbol_completion_list_fn sounds more like a typedef name!

And who could possibly complain about shortening symtab.[ch]. Those files are already a little bloated with non-symtab stuff.

I see no issues with this patch.

Keith


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]