This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Import setenv and unsetenv from gnulib


On Tuesday, July 04 2017, Anton Kolesov wrote:

>> > Patch [1] broke a build on MinGW hosts, because MinGW doesn't provide
>> > POSIX functions setenv () and unsetenv ().  This can be fixed by using
>> > implementations from gnulib.
>> >
>> > [1] https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=9a6c7d9c0
>> >
>> 
>> We need commit hash and subject only, like
>> 
>> 9a6c7d9c0 (C++ify gdb/common/environ.c)
>> 
>> Did you run regression test on x86-linux?  If there is no regression, patches is
>> good to me.
>
> If I run "make check-gdb", I don't see any obvious new errors from this patch.
> Unfortunately results are a little bit volatile - some tests sporadically fail even
> if I run them with same GDB build and sources, even without this patch - I've run
> testsuite five times and got five similar, but different results.

Yeah, our testsuite has racy fails which are well known.  What are the
tests that fail sporadically?

-- 
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF  31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]