This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Import setenv and unsetenv from gnulib
- From: Sergio Durigan Junior <sergiodj at redhat dot com>
- To: Anton Kolesov <Anton dot Kolesov at synopsys dot com>
- Cc: Yao Qi <qiyaoltc at gmail dot com>, "gdb-patches\@sourceware.org" <gdb-patches at sourceware dot org>, Francois Bedard <Francois dot Bedard at synopsys dot com>
- Date: Tue, 04 Jul 2017 16:26:50 -0400
- Subject: Re: [PATCH] Import setenv and unsetenv from gnulib
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=sergiodj at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com E57B94E4CA
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com E57B94E4CA
- References: <87shid8rt3.fsf@redhat.com> <20170703162737.8386-1-Anton.Kolesov@synopsys.com> <CAH=s-POJzGx1Ab28a56ru2S6jHugH-gikJJgFziiR4ZRSc0-Tg@mail.gmail.com> <39A54937CC95F24AA2F794E2D2B66B135876DD39@DE02WEMBXB.internal.synopsys.com>
On Tuesday, July 04 2017, Anton Kolesov wrote:
>> > Patch [1] broke a build on MinGW hosts, because MinGW doesn't provide
>> > POSIX functions setenv () and unsetenv (). This can be fixed by using
>> > implementations from gnulib.
>> >
>> > [1] https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=9a6c7d9c0
>> >
>>
>> We need commit hash and subject only, like
>>
>> 9a6c7d9c0 (C++ify gdb/common/environ.c)
>>
>> Did you run regression test on x86-linux? If there is no regression, patches is
>> good to me.
>
> If I run "make check-gdb", I don't see any obvious new errors from this patch.
> Unfortunately results are a little bit volatile - some tests sporadically fail even
> if I run them with same GDB build and sources, even without this patch - I've run
> testsuite five times and got five similar, but different results.
Yeah, our testsuite has racy fails which are well known. What are the
tests that fail sporadically?
--
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/