This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 06/40] Expression completer should not match explicit location options


On 06/29/2017 11:56 AM, Pedro Alves wrote:

> The patch fixes this by having the expression_completer function
> bypass the function that completes explicit locations:
> 
>     /* Not ideal but it is what we used to do before...  */
>  -  return location_completer (ignore, p, word);
>  +  return linespec_location_completer (ignore, text, word);
> 

Hmm, reading this back made my realize that I'm dropping "p"
here, which is computed just above.  That doesn't make a difference
to the test added by 37cd5d19fecc (2008), which was the commit
that added that code.  Hmm, looks like that's a bit of dead code
we can remove.

Thanks,
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]