This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 09/25] Use target_desc fields expedite_regs and xmltarget ifndef IN_PROCESS_AGENT
On 06/28/2017 06:42 PM, Pedro Alves wrote:
> On 06/28/2017 05:15 PM, Pedro Alves wrote:
>> On 06/12/2017 09:41 AM, Yao Qi wrote:
>>> struct target_desc is used by both GDBserver and IPA, but fields expedite_regs
>>> and xmltarget are only used in GDBserver, so this patch wraps these two fields
>>> by ifndef IN_PROCESS_AGENT. This patch also changes regformats/regdat.sh to
>>> generate .c files in this way too.
>>
>> OK.
>
> Actually, I tried building the series at some intermediate patch,
> and noticed that the build was broken. This is the first patch
> that breaks it:
>
> ...
> amd64-linux.c: In function ‘void init_registers_amd64_linux()’:
> amd64-linux.c:103:11: error: ‘struct target_desc’ has no member named
> ‘expedite_regs’
> result->expedite_regs = expedite_regs_amd64_linux;
> ^
> amd64-linux.c:104:11: error: ‘struct target_desc’ has no member named
> ‘xmltarget’
> result->xmltarget = xmltarget_amd64_linux;
> ^
> ...
Hmm, turns out that I need to remove the generated .c files
manually. "make clean" didn't remove them. Now that they're
gone, gdbserver builds cleanly.
Thanks,
Pedro Alves