This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v2] gdb: ADI support


Hi Yao,

It doesn't look like the proposed file naming convention for new functionality
is forthcoming. I've therefore added the ADI support to file sparc64-tdep.c and
submitted a revised patch which addresses all but one of your comments. The one
that's left out is to define ADI as a qXfer object for reading from and writing
to the ADI maps file through target layer.

Thanks again for your comments.

----- Original Message -----
From: qiyaoltc@gmail.com
To: weimin.pan@oracle.com
Cc: gdb-patches@sourceware.org
Sent: Wednesday, June 21, 2017 9:47:54 AM GMT -08:00 US/Canada Pacific
Subject: Re: [PATCH v2] gdb: ADI support

On Wed, Jun 21, 2017 at 5:22 PM, Wei-min Pan <weimin.pan@oracle.com> wrote:
>
> Thanks for bringing up and taking care of  this matter. I will create
> sparc64-tdep-adi.c for SPARC
> ADI support.
>

Hold on :), I don't think people agreed on the new
convention yet.  Before the agreement is made,
sparc64-tdep.c is still the right place to add adi stuff.

-- 
Yao (齐尧)


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]