This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 07/25] Lazily and dynamically create i386-linux target descriptions
- From: Pedro Alves <palves at redhat dot com>
- To: Yao Qi <qiyaoltc at gmail dot com>, gdb-patches at sourceware dot org
- Date: Tue, 20 Jun 2017 12:01:23 +0100
- Subject: Re: [PATCH 07/25] Lazily and dynamically create i386-linux target descriptions
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx08.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx08.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 869F3C00EB0C
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 869F3C00EB0C
- References: <1497256916-4958-1-git-send-email-yao.qi@linaro.org> <1497256916-4958-8-git-send-email-yao.qi@linaro.org>
On 06/12/2017 09:41 AM, Yao Qi wrote:
> Instead of using pre-generated target descriptions, this patch
> changes GDB to lazily and dynamically create target descriptions
> according to the target hardware capability (xcr0 in i386).
> This support any combination of target features.
>
> This patch also adds a unit test to make sure dynamically generated
> tdesc are identical to these generated from xml files.
I don't see the unit test in the patch.
Can you say something about the "regnum = %ld" change? Is it
related to the rest of the patch?
>
> 2017-04-27 Yao Qi <yao.qi@linaro.org>
>
> * i386-linux-tdep.c (i386_linux_read_description): Generate
> target description if it doesn't exist.
> [GDB_SELF_TEST] (i386_linux_read_description_test): New unit test.
> (_initialize_i386_linux_tdep) [GDB_SELF_TEST]: Register unit test.
Leading TAB vs spaces.
> +private:
> + /* The register number to use for the next register we see. */
> + int next_regnum = 0;
> };
"m_" prefix.
Thanks,
Pedro Alves