This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 0/5] Remove a few hurdles of compiling with clang


On 6/14/17 6:45 AM, Pedro Alves wrote:
> Or better even, just don't skip two registers at a time?
> The code is manually printing two columns on each iteration.
> How about the patchlet below instead?  I'd call it a clean up on
> its own right.

I prefer this fix and agree.  Other places that try to print registers
in columns (mips-tdep.c) iterate one register at a time and make the
newline conditional, so this pattern is consistent with that.

-- 
John Baldwin


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]