This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Introduce "set debug separate-debug-file"
- From: Simon Marchi <simon dot marchi at ericsson dot com>
- To: Pedro Alves <palves at redhat dot com>, <gdb-patches at sourceware dot org>
- Date: Thu, 25 May 2017 13:33:00 +0200
- Subject: Re: [PATCH] Introduce "set debug separate-debug-file"
- Authentication-results: sourceware.org; auth=none
- Authentication-results: sourceware.org; dkim=none (message not signed) header.d=none;sourceware.org; dmarc=none action=none header.from=ericsson.com;
- References: <1495668248-16716-1-git-send-email-simon.marchi@ericsson.com> <c540c17c-d40f-5d79-b813-92cc0f1f6e6f@redhat.com>
- Spamdiagnosticmetadata: NSPM
- Spamdiagnosticoutput: 1:99
On 2017-05-25 01:07 PM, Pedro Alves wrote:
> I think this is a good idea.
>
> You're missing NEWS and manual bits though.
>
> On 05/25/2017 12:24 AM, Simon Marchi wrote:
>
>> + if (separate_debug_file_debug)
>> + printf_unfiltered (" Trying %s\n", link);
>> +
>
> Missing "_()" in several of these new calls.
>
>> +
>> + add_setshow_boolean_cmd ("separate-debug-file", no_class,
>> + &separate_debug_file_debug, _("\
>> +Set printing of separate debug info file search debug."), _("\
>> +Show printing of separate debug info file search debug."), _("\
>> +When on, GDB will print the searched locations while looking for separate \
>> +debug info files."), NULL, NULL, &setdebuglist, &showdebuglist);
>
> FWIW, I think it's better to avoid future tense when possible:
>
> "When on, GDB prints the searched locations"
Thanks for the comments, sending a v2 now.
Simon