This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH v2 15/19] Respect piece offset for DW_OP_bit_piece

From: Yao Qi <qiyaoltc at gmail dot com>
To: Andreas Arnez <arnez at linux dot vnet dot ibm dot com>
Cc: gdb-patches at sourceware dot org
Date: Tue, 16 May 2017 22:08:11 +0100
Subject: Re: [PATCH v2 15/19] Respect piece offset for DW_OP_bit_piece
Authentication-results: sourceware.org; auth=none
References: <1494352015-10465-1-git-send-email-arnez@linux.vnet.ibm.com> <1494352015-10465-16-git-send-email-arnez@linux.vnet.ibm.com>

On 17-05-09 19:46:11, Andreas Arnez wrote:
> So far GDB ignores the piece offset of all kinds of DWARF bit
> pieces (DW_OP_bit_piece) and treats such pieces as if the offset was zero.
> 
> This is fixed, and an appropriate test is added.
> 
> gdb/ChangeLog:
> 
> 	* dwarf2loc.c (read_pieced_value): Respect the piece offset, as
> 	given by DW_OP_bit_piece.
> 	(write_pieced_value): Likewise.
> 
>   Andreas Arnez  <arnez@linux.vnet.ibm.com>
> 
> 	* gdb.dwarf2/var-access.exp: Add test for composite location with
> 	nonzero piece offsets.

LGTM.

-- 
Yao (齐尧)

References:
- [PATCH v2 00/19] Various DWARF piece fixes
  - From: Andreas Arnez
- [PATCH v2 15/19] Respect piece offset for DW_OP_bit_piece
  - From: Andreas Arnez

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]