This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [RFA 04/23] Use gdb_file_up in fbsd-nat.c

From: John Baldwin <jhb at freebsd dot org>
To: gdb-patches at sourceware dot org
Cc: Tom Tromey <tom at tromey dot com>
Date: Wed, 03 May 2017 16:50:48 -0700
Subject: Re: [RFA 04/23] Use gdb_file_up in fbsd-nat.c
Authentication-results: sourceware.org; auth=none
References: <20170503224626.2818-1-tom@tromey.com> <20170503224626.2818-5-tom@tromey.com>

On Wednesday, May 03, 2017 04:46:07 PM Tom Tromey wrote:
> This updates fbsd-nat.c to use gdb_file_up.  This removes a use of a
> cleanup, and helps remove make_cleanup_fclose in a later patch.
> 
> I have no way to test this patch.

This looks fine to me.  On the other hand, it's also not used on most
modern versions of FreeBSD (so I don't have a good way to test it either).
The new interface using sysctl has been available since FreeBSD 7.1
(released in January of 2009).

-- 
John Baldwin

References:
- [RFA 00/23] More miscellaneous C++-ification
  - From: Tom Tromey
- [RFA 04/23] Use gdb_file_up in fbsd-nat.c
  - From: Tom Tromey

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]