This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 01/10] Standardize darwin's lm_info


On 2017-04-28 11:57, Pedro Alves wrote:
On 04/26/2017 11:46 PM, Simon Marchi wrote:
From: Simon Marchi <simon.marchi@polymtl.ca>

Darwin's lm_info structure is used a little bit differently than the
other solib implementations.  The other implementations first allocate
an so_list object, then instanciate their specific lm_info structure,
and assign it to so_list::lm_info.

The Darwin implementation allocates both at the same time
(darwin_so_list). This patch changes it to be like the others, so that
we'll be able to do some generalizations later.

Funny, so this port was already "inheriting" from so_list.

Indeed. But I thought it would be better as a first step to make all of them work in a similar way. If we proceed with inheriting from so_list, we'll do them all at once

LGTM.

Thanks,
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]