This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 01/10] Standardize darwin's lm_info
- From: Pedro Alves <palves at redhat dot com>
- To: Simon Marchi <simon dot marchi at ericsson dot com>, gdb-patches at sourceware dot org
- Cc: Simon Marchi <simon dot marchi at polymtl dot ca>
- Date: Fri, 28 Apr 2017 16:57:17 +0100
- Subject: Re: [PATCH 01/10] Standardize darwin's lm_info
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx03.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx03.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com A2A7B80064
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com A2A7B80064
- References: <20170426224706.27988-1-simon.marchi@ericsson.com> <20170426224706.27988-2-simon.marchi@ericsson.com>
On 04/26/2017 11:46 PM, Simon Marchi wrote:
> From: Simon Marchi <simon.marchi@polymtl.ca>
>
> Darwin's lm_info structure is used a little bit differently than the
> other solib implementations. The other implementations first allocate
> an so_list object, then instanciate their specific lm_info structure,
> and assign it to so_list::lm_info.
>
> The Darwin implementation allocates both at the same time
> (darwin_so_list). This patch changes it to be like the others, so that
> we'll be able to do some generalizations later.
Funny, so this port was already "inheriting" from so_list.
LGTM.
Thanks,
Pedro Alves