This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch+8.0] release branch: Fix: --enable-werror
- From: Pedro Alves <palves at redhat dot com>
- To: Jan Kratochvil <jan dot kratochvil at redhat dot com>, gdb-patches at sourceware dot org
- Cc: Joel Brobecker <brobecker at adacore dot com>, Sergio Durigan Junior <sergiodj at redhat dot com>
- Date: Fri, 21 Apr 2017 15:03:50 +0100
- Subject: Re: [patch+8.0] release branch: Fix: --enable-werror
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx10.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx10.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 7DE321602BD
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 7DE321602BD
- References: <20170421085204.GA5501@host1.jankratochvil.net>
On 04/21/2017 09:52 AM, Jan Kratochvil wrote:
> Hi,
>
> gdb-8.0-branch
> ./configure --enable-werror --enable-targets=all
> aarch64-tdep.c:3045:13: error: ‘void selftests::aarch64_process_record_test()’ declared ‘static’ but never defined [-Werror=unused-function]
> arm-tdep.c:9601:13: error: ‘void selftests::arm_record_test()’ declared ‘static’ but never defined [-Werror=unused-function]
>
> OK for check-in?
OK.
>
> Please do not tell me release branches do not support --enable-werror as this
> is due to a sourcebase bug, not due to some unexpected compiler
> incompatibility.
Certainly.
> Sergio: Shouldn't it be also buildbot-tested?
Sounds like a good idea.
Thanks,
Pedro Alves