This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v3] C++ify gdb/common/environ.c
- From: Pedro Alves <palves at redhat dot com>
- To: Simon Marchi <simon dot marchi at polymtl dot ca>, Sergio Durigan Junior <sergiodj at redhat dot com>
- Cc: GDB Patches <gdb-patches at sourceware dot org>
- Date: Wed, 19 Apr 2017 17:29:56 +0100
- Subject: Re: [PATCH v3] C++ify gdb/common/environ.c
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 2D61B3B72D
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 2D61B3B72D
- References: <20170413040455.23996-1-sergiodj@redhat.com> <20170418030319.12637-1-sergiodj@redhat.com> <843eaee444605d981d452a1801a24ebf@polymtl.ca>
On 04/19/2017 05:56 AM, Simon Marchi wrote:
>>
>> + return (char *) this->m_environ_map.at (var).c_str ();
>
> You can remove the cast here.
And while at it, please write "m_environ_map" without the leading
"this->".
(Likewise other similar cases, I haven't looked at the patch in
any detail.)
Thanks,
Pedro Alves