This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Make environ.exp run on all platforms (and create info-program.exp)
- From: Sergio Durigan Junior <sergiodj at redhat dot com>
- To: Luis Machado <lgustavo at codesourcery dot com>
- Cc: GDB Patches <gdb-patches at sourceware dot org>
- Date: Thu, 13 Apr 2017 14:26:45 -0400
- Subject: Re: [PATCH] Make environ.exp run on all platforms (and create info-program.exp)
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx04.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx04.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=sergiodj at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 1AED77F7C0
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 1AED77F7C0
- References: <20170331172901.23402-1-sergiodj@redhat.com> <f4e1c86b-e6fb-0bf9-fc34-d609fbd17442@codesourcery.com>
Thanks for the review, Luis.
On Thursday, April 13 2017, Luis Machado wrote:
> On 03/31/2017 12:29 PM, Sergio Durigan Junior wrote:
>> This has been on my TODO list for a while. There's a really old bug
>> about this (PR testsuite/8595), and there was no reason for
>> environ.exp to be specific for hppa* targets. So this patch removes
>> this constraint, modernizes the testcase, and cleans up some things.
>> Most of the tests remained, and some were rewritten (especially the
>> one that checks if "show environment" works, which is something kind
>> of hard to do).
>>
>> As a bonus, I'm adding a separated info-program.exp file containing
>> all the tests related to "info program" that were present on
>> environ.exp.
>>
>> Tested locally, everything still passes.
>
> I haven't gone through the entire patch, but i have a question. Was
> this exercised for bare-metal?
Nope, I haven't had the chance to test this on bare-metal.
> If not, please make sure this test works correctly on bare-metal
> targets before assuming it does just because it passes on Linux-hosted
> tests. Otherwise we may have spurious failures due to tests that are
> not supposed to be executed in a bare-metal environment.
>
> If you don't have access to bare-metal testing, i could give this a
> try (it may take a couple days though) and report back.
I don't think I have access to a bare-metal easily; if you could test
this, I'd really appreciate.
Thanks,
--
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/