This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 1/8] watch_command_1: Fix dangling frame access


On 04/13/2017 10:34 AM, Yao Qi wrote:
> Pedro Alves <palves@redhat.com> writes:
> 
>> -  if (exp_valid_block && frame)
>> +  if (exp_valid_block && wp_frame)
> 
> if (exp_valid_block != NULL && wp_frame != NULL)
> 
> Patch is good to me.

Thanks!  I did that change, and pushed patches 1-6, up until the
one that add cdtors to struct inferior.

I went ahead because last my non-POD + memset detector flagged 
struct inferior, and also because I saw that Sergio's C++fy
environ patch was adding yet another non-POD member to
struct inferior.

Thanks,
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]