This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [RFA 08/14] Remove some cleanups from gnu-v3-abi.c

From: Simon Marchi <simon dot marchi at polymtl dot ca>
To: Tom Tromey <tom at tromey dot com>
Cc: gdb-patches at sourceware dot org
Date: Mon, 10 Apr 2017 00:08:24 -0400
Subject: Re: [RFA 08/14] Remove some cleanups from gnu-v3-abi.c
Authentication-results: sourceware.org; auth=none
References: <20170408201208.2672-1-tom@tromey.com> <20170408201208.2672-9-tom@tromey.com>

On 2017-04-08 16:12, Tom Tromey wrote:

@@ -821,7 +812,7 @@ compare_value_and_voffset (const void *a, constvoid *b)


 static void
 compute_vtable_size (htab_t offset_hash,
-		     VEC (value_and_voffset_p) **offset_vec,
+		     std::vector<value_and_voffset *> *offset_vec,
 		     struct value *value)


Pass the vector by reference?  Otherwise, LGTM.

Simon

Follow-Ups:
- Re: [RFA 08/14] Remove some cleanups from gnu-v3-abi.c
  - From: Tom Tromey

References:
- [RFA 00/14] miscellaneous C++-ificiation
  - From: Tom Tromey
- [RFA 08/14] Remove some cleanups from gnu-v3-abi.c
  - From: Tom Tromey

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]