This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 1/2] This patch fixes GDBServer's run control for single stepping
- From: Yao Qi <qiyaoltc at gmail dot com>
- To: Antoine Tremblay <antoine dot tremblay at ericsson dot com>
- Cc: Pedro Alves <palves at redhat dot com>, "gdb-patches\@sourceware.org" <gdb-patches at sourceware dot org>
- Date: Mon, 03 Apr 2017 13:41:24 +0100
- Subject: Re: [PATCH 1/2] This patch fixes GDBServer's run control for single stepping
- Authentication-results: sourceware.org; auth=none
- References: <20161129120702.9490-1-antoine.tremblay@ericsson.com> <20170127150139.GB24676@E107787-LIN> <wwokwpdg5vxa.fsf@ericsson.com> <CAH=s-PP-i3v_Fr=QeWt9BQeJzjCHtW79nGYpJ9hF-Bb=OBo89Q@mail.gmail.com> <wwokr33o5pkb.fsf@ericsson.com> <CAH=s-PO98nCE4UB9ag+V=M2mBnZT0FOeHV3d7mFMLYe1+v=mFg@mail.gmail.com> <wwok8tps8yo2.fsf@ericsson.com> <2255ed6f-a146-026c-f871-00e9a33dfcf0@redhat.com> <wwokwpcp7fvn.fsf@ericsson.com> <b5fb81d1-66fc-68c2-9785-ffa487de59e0@redhat.com> <wwoktw7t7bzy.fsf@ericsson.com> <CAH=s-PPx+SjoE0DkTKKNqg4Dr4zHFNt6QeC-XXT_LoXVh004iw@mail.gmail.com> <wwokh93s1he3.fsf@ericsson.com> <CAH=s-PPrB=s6d9Q07W=-b8Sz9umh6_Lj24PyO4x99Z3QrtfmzQ@mail.gmail.com> <wwokzig4l0i1.fsf@ericsson.com> <86d1cy4umo.fsf@gmail.com> <wwokvaqqlipt.fsf@ericsson.com> <86d1cxwgpk.fsf@gmail.com> <wwoktw69l31p.fsf@ericsson.com>
Antoine Tremblay <antoine.tremblay@ericsson.com> writes:
> I think maybe the best solution would be to abstract only that part of
> get_next_pc in a function: the if block starting with if
> (self->has_thumb2_breakpoint) around line 301.
>
> And have only that part return the next_pc + the breakpoint kind, this
> would avoid breaking all the virtual get_next_pc functions just for that
> case and allow the same code to be used in kind_from_current_state.
>
> We'll still redo the work but at least the code will be in one
> place. WDYT ?
That should be fine, although I am not exactly sure what are you
going to do.
--
Yao (齐尧)