This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 4/5 v2] arc: Add disassembler helper
- From: Eli Zaretskii <eliz at gnu dot org>
- To: Anton Kolesov <Anton dot Kolesov at synopsys dot com>
- Cc: gdb-patches at sourceware dot org, Francois dot Bedard at synopsys dot com
- Date: Wed, 15 Mar 2017 17:57:59 +0200
- Subject: Re: [PATCH 4/5 v2] arc: Add disassembler helper
- Authentication-results: sourceware.org; auth=none
- References: <20170315151738.28651-1-Anton.Kolesov@synopsys.com>
- Reply-to: Eli Zaretskii <eliz at gnu dot org>
> From: Anton Kolesov <Anton.Kolesov@synopsys.com>
> Cc: Anton Kolesov <Anton.Kolesov@synopsys.com>, Francois Bedard <Francois.Bedard@synopsys.com>
> Date: Wed, 15 Mar 2017 18:17:38 +0300
>
> Changes in v2:
>
> * Add NEWS entry for "maint print arc arc-instruction" command.
> * Fix grammar in the comment.
> * Add arc_disassemble_info function, which was used in this patch, but was
> declared and defined only in the next patch in a sequence.
> * Merge arch/arc-insn.{c,h} files into arc-tdep.{c,h}
> * Improve formatting of output of "maint print arc arc-instruction" command:
> add whitespaces around the "=" symbol.
> * Use "prepare_for" in test cases.
> * Reformat test sequence as a list of string.
OK for the documentation parts.
Thanks.