This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v2] inf-ptrace: Do not stop memory transfers after a single word
- From: Andreas Arnez <arnez at linux dot vnet dot ibm dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: gdb-patches at sourceware dot org, Simon Marchi <simon dot marchi at ericsson dot com>
- Date: Tue, 14 Mar 2017 19:24:44 +0100
- Subject: Re: [PATCH v2] inf-ptrace: Do not stop memory transfers after a single word
- Authentication-results: sourceware.org; auth=none
- References: <m3bmt3eucs.fsf@oc1027705133.ibm.com> <6640b187-bad5-a584-73b0-4e151a85fc3c@redhat.com>
On Tue, Mar 14 2017, Pedro Alves wrote:
> On 03/14/2017 03:44 PM, Andreas Arnez wrote:
>> Version 1 is here:
>>
>> https://sourceware.org/ml/gdb-patches/2017-03/msg00043.html
>>
>> Changes from version 1:
>>
>> * "unsigned" -> "unsigned int"
>>
>> * Compare pointers with NULL explicitly.
>
> Pedantically, it should be "if (errno != 0)" and
> "*xfered_len != 0 ? ...." as well.
OK, changed those as well.
>
>>
>> * Move the ptrace peek/poke loop to a separate routine for better
>> readability.
>>
>> OK to apply?
>
> LGTM.
Thanks!
I noticed that the commit message is now slightly wrong, because GDB now
*does* exploit writing to /proc/<pid>/mem. Fixed the commit message
accordingly.
Pushed with the above changes.
--
Andreas