This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[PATCH obv] Use range-based for loop in remote_add_target_side_condition
- From: Simon Marchi <simon dot marchi at ericsson dot com>
- To: <gdb-patches at sourceware dot org>
- Cc: Simon Marchi <simon dot marchi at ericsson dot com>
- Date: Mon, 27 Feb 2017 13:55:35 -0500
- Subject: [PATCH obv] Use range-based for loop in remote_add_target_side_condition
- Authentication-results: sourceware.org; auth=none
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=simon dot marchi at ericsson dot com;
- Spamdiagnosticmetadata: NSPM
- Spamdiagnosticoutput: 1:99
FYI, I pushed this as obvious.
Using a range based for loop makes this code a bit more clean and
readable.
The comment above is clearly erroneous, so I've updated it.
gdb/ChangeLog:
* remote.c (remote_add_target_side_condition): Use range-based
for loop. Update comment.
---
gdb/ChangeLog | 5 +++++
gdb/remote.c | 6 ++----
2 files changed, 7 insertions(+), 4 deletions(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index a7be8266ea..a872f1bfb9 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2017-02-27 Simon Marchi <simon.marchi@ericsson.com>
+
+ * remote.c (remote_add_target_side_condition): Use range-based
+ for loop. Update comment.
+
2017-02-27 Yao Qi <yao.qi@linaro.org>
* f-typeprint.c (f_print_type): Check "varstring" is empty first.
diff --git a/gdb/remote.c b/gdb/remote.c
index 87fb6e02ea..aedbd08cc4 100644
--- a/gdb/remote.c
+++ b/gdb/remote.c
@@ -9664,11 +9664,9 @@ remote_add_target_side_condition (struct gdbarch *gdbarch,
xsnprintf (buf, buf_end - buf, "%s", ";");
buf++;
- /* Send conditions to the target and free the vector. */
- for (int ix = 0; ix < bp_tgt->conditions.size (); ix++)
+ /* Send conditions to the target. */
+ for (struct agent_expr *aexpr : bp_tgt->conditions)
{
- struct agent_expr *aexpr = bp_tgt->conditions[ix];
-
xsnprintf (buf, buf_end - buf, "X%x,", aexpr->len);
buf += strlen (buf);
for (int i = 0; i < aexpr->len; ++i)
--
2.11.0