Re: [PATCH] gdb: Add native support for Linux SH

[Luis Machado <lgustavo at codesourcery dot com>]

Hi John,

Thanks for the patch.

It would be nice to have the patch split into more manageable/logical 
bits. It would make it both easier and quicker to review.

For example, splitting gdb/testsuite, gdb/config, Makefile/configure, 
native (sh-linux-nat) and potentially sh-tdep and sh-linux changes into 
their own patches.

Regards,
Luis

On 02/10/2017 02:55 PM, John Paul Adrian Glaubitz wrote:
> Signed-off-by: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
> ---
>  gdb/Makefile.in                      |   2 +
>  gdb/config/sh/linux.mh               |  14 +
>  gdb/config/sh/nm-linux.h             |  54 ++++
>  gdb/config/sh/xm-linux.h             |  32 +++
>  gdb/configure.host                   |   1 +
>  gdb/sh-linux-nat.c                   | 268 ++++++++++++++++++
>  gdb/sh-linux-tdep.c                  | 516 +++++++++++++++++++++++++++++++++++
>  gdb/sh-tdep.c                        |  54 ++--
>  gdb/sh-tdep.h                        |  53 +++-
>  gdb/testsuite/gdb.asm/asm-source.exp |   5 +
>  gdb/testsuite/gdb.asm/sh-linux.inc   |  78 ++++++
>  gdb/testsuite/gdb.asm/sh.inc         |   3 +-
>  12 files changed, 1049 insertions(+), 31 deletions(-)
>  create mode 100644 gdb/config/sh/linux.mh
>  create mode 100644 gdb/config/sh/nm-linux.h
>  create mode 100644 gdb/config/sh/xm-linux.h
>  create mode 100644 gdb/sh-linux-nat.c
>  create mode 100644 gdb/testsuite/gdb.asm/sh-linux.inc