This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] aarch64 sim bit/bif bug fix
- From: Nick Clifton <nickc at redhat dot com>
- To: Jim Wilson <jim dot wilson at linaro dot org>, gdb-patches at sourceware dot org
- Date: Mon, 13 Feb 2017 15:36:39 +0000
- Subject: Re: [PATCH] aarch64 sim bit/bif bug fix
- Authentication-results: sourceware.org; auth=none
- References: <CABXYE2UVXL+xv3qK9YzGeqNhtxDnSOs0FV1qjNc99okrvhGceg@mail.gmail.com>
Hi Jim,
> This fixes the bit and bif instructions. The code is using u32
> set/get, but 16/8 loop bounds, which gives out of range errors. Also,
> it is computing the value wrong, as it is a bitwise operation, not an
> operation checking byte/word values for zero/non-zero. I rewrote the
> code a little to make the operation more obvious. It now looks more
> like bsl which is a closely related instruction.
>
> The testcase fails without the patch and works with the patch. GCC C
> testsuite failures drop from 1701 to 1590 (-111).
Approved - please apply.
Cheers
Nick