This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v5 1/9] btrace: Count gaps as one instruction explicitly.
- From: Doug Evans <xdje42 at gmail dot com>
- To: Tim Wiederhake <tim dot wiederhake at intel dot com>
- Cc: gdb-patches at sourceware dot org, markus dot t dot metzger at intel dot com, palves at redhat dot com
- Date: Sun, 12 Feb 2017 19:57:23 -0800
- Subject: Re: [PATCH v5 1/9] btrace: Count gaps as one instruction explicitly.
- Authentication-results: sourceware.org; auth=none
- References: <1485527996-32506-1-git-send-email-tim.wiederhake@intel.com> <1485527996-32506-2-git-send-email-tim.wiederhake@intel.com>
> This gives all instructions, including gaps, a unique number. Add a function
> to retrieve the error code if a btrace instruction iterator points to an
> invalid instruction.
>
> 2017-01-27 Tim Wiederhake <tim.wiederhake@intel.com>
>
> gdb/ChangeLog:
>
> * btrace.c (ftrace_call_num_insn, btrace_insn_get_error): New function.
> (ftrace_new_function, btrace_insn_number, btrace_insn_cmp,
> btrace_find_insn_by_number): Remove special case for gaps.
> * btrace.h (btrace_insn_get_error): New export.
> (btrace_insn_number, btrace_find_insn_by_number): Adjust comment.
> * record-btrace.c (btrace_insn_history): Print number for gaps.
> (record_btrace_info, record_btrace_goto): Handle gaps.
LGTM