This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA 1/5] Remove some ui_out-related cleanups from Python


On Wed, Feb 8, 2017 at 3:51 PM, Pedro Alves <palves@redhat.com> wrote:

>> Pedro> Patch LGTM with Trevor's and Simon's nits  addressed.
>>
>> I have that done locally, but I've just been waiting until your series
>> lands, so I can rebase.  And then maybe the option stuff wouldn't be
>> needed anyway?  I don't remember the details from your branch, I was
>> just waiting for the big rebase to find out.
>
> My series is all in master.  I think we'll still need your patch, since I only
> touched ui_files.  I haven't done anything with ui_out list/tuple building.

I haven't been following much lately due to programming mostly in
languages unsupported by gdb apologies if this has been hashed out
before.

Wondering if this would be a good opportunity to try and transition
ui_out_list construction into a more type safe manner, e.g.

result ==> variable "=" value
list ==> "[]" | "[" value ( "," value )* "]" | "[" result ( "," result )* "]"

currently when building a list, it didn't specify whether you were
declaring a list of results or a list of values, unless/until the
first value or result was added, and IIRC this | property wasn't
really explicitly enforced.

it'd be nice to migrate this to something like:
result_list, value_list, deprecated_unspecified_list, It would be nice
to know if/when you guys think it would be a convenient time to
introduce such a change so I could get back up to speed...


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]