This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
RE: [PATCH v3 2/5] btrace: allow recording to be started (and stopped) for running threads
- From: "Metzger, Markus T" <markus dot t dot metzger at intel dot com>
- To: Pedro Alves <palves at redhat dot com>, "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Cc: Simon Marchi <simon dot marchi at ericsson dot com>
- Date: Wed, 1 Feb 2017 08:53:09 +0000
- Subject: RE: [PATCH v3 2/5] btrace: allow recording to be started (and stopped) for running threads
- Authentication-results: sourceware.org; auth=none
- References: <1485770743-6603-1-git-send-email-markus.t.metzger@intel.com> <1485770743-6603-3-git-send-email-markus.t.metzger@intel.com> <add8123b-e7c2-7baf-0d81-74b1aefcb036@redhat.com> <A78C989F6D9628469189715575E55B2340046F6C@IRSMSX104.ger.corp.intel.com> <1b369026-46a2-199c-ec6d-8302a462c10f@redhat.com>
> > I was also thinking of changing the error messages to refer to the argument
> > thread but that would make them less clear when PTID really refers to the
> > selected thread - which should be the case most of the time if not always.
> >
> > Maybe this is not an issue in practice and the "selected thread" errors are
> > understandable enough. What do you think?
>
> I think we may be able to sidestep deciding this. :-)
That seems to work. I added a few tests to cover other record commands
while threads are running.
Thanks,
Markus.
Intel Deutschland GmbH
Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Christin Eisenschmid, Christian Lamprechter
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928