This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] contrib/gdb-add-index.sh: chmod u+w


On 01/06/2017 07:33 PM, Jan Kratochvil wrote:
> On Fri, 06 Jan 2017 19:37:10 +0100, Jan Kratochvil wrote:
>> in Fedora 24 it still worked, in Fedora 25 it does not - *-debuginfo.rpm
>> no longer have the .gdb_index accelerating section now.
>>
>> It happens because:
>> objcopy: unable to copy file 'foo.debug'; reason: Permission denied
>>
>> *.debug files in Fedora were always 444 but the time gdb-add-index is run is
>> still before the *.debug split and in Fedora 24 the files were -rwxr-xr-x
>> that time while in Fedora 25 they are apparently no longer w.
> 
> The problem was in Fedora /usr/lib/rpm/find-debuginfo.sh script regression.
> 
> This GDB contrib/ patch is not required to make Fedora working.
> 
> Although I find it as a good improvement anyway so keeping it here submitted.

Not sure I agree; looks like a hack to me.  :-/
Since it's not needed, it seems better to me to keep the code simpler.

Thanks,
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]