This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v3] Fix inferior memory reading in GDBServer for arm/aarch32
- From: Yao Qi <qiyaoltc at gmail dot com>
- To: Antoine Tremblay <antoine dot tremblay at ericsson dot com>
- Cc: qiyaoltc at gmail dot co, gdb-patches at sourceware dot org
- Date: Mon, 9 Jan 2017 17:30:56 +0000
- Subject: Re: [PATCH v3] Fix inferior memory reading in GDBServer for arm/aarch32
- Authentication-results: sourceware.org; auth=none
- References: <20161209122339.GG13661@E107787-LIN> <20161209124625.31861-1-antoine.tremblay@ericsson.com>
On 16-12-09 07:46:25, Antoine Tremblay wrote:
>
> This situation is tested with non-stop-fair-events.exp.
>
> In other words, single-step breakpoints are installed in proceed_one_lwp
> for each thread. GDBserver proceeds two threads for resume_step, as
> requested by GDB, and the thread proceeded later may see the single-step
> breakpoints installed for the thread proceeded just now.
>
> Tested on gdbserver-native/-m{thumb,arm} no regressions.
I assume this patch fixes fails in non-stop-fair-events.exp.
>
> gdb/gdbserver/ChangeLog:
>
> * linux-aarch32-low.c (arm_breakpoint_kind_from_pc): Use
> target_read_memory.
> * linux-arm-low.c (get_next_pcs_read_memory_unsigned_integer): Likewise.
> (get_next_pcs_syscall_next_pc): Likewise.
Patch is good to me.
--
Yao (齐尧)