This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [pushed] gdb: Constify solib_find (Re: [RFA 2/8] Use class to manage BFD reference counts)

From: Tom Tromey <tom at tromey dot com>
To: Pedro Alves <palves at redhat dot com>
Cc: Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
Date: Tue, 20 Dec 2016 11:04:58 -0700
Subject: Re: [pushed] gdb: Constify solib_find (Re: [RFA 2/8] Use class to manage BFD reference counts)
Authentication-results: sourceware.org; auth=none
References: <1480395946-10924-1-git-send-email-tom@tromey.com> <1480395946-10924-3-git-send-email-tom@tromey.com> <cce47d1e-b2e2-dcdf-5c36-b318ed1c77db@redhat.com> <87fulseza9.fsf@tromey.com> <ed9078ef-a1d8-46be-a15f-dbddecc52f83@redhat.com>

>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:

Tom> I did this, but it's a bit ugly as solib_find isn't const-correct.

Pedro> That doesn't look hard to fix.  I've pushed in the patch below.
Pedro> What uglification does this allow removing?

Huh.  I had taken a stab at this but I thought I ran into some morass,
so I stopped.  Oh well.

Anyway what this enables is a change from &str[0] to str.c_str().

Tom

References:
- Re: [RFA 2/8] Use class to manage BFD reference counts
  - From: Pedro Alves
- Re: [RFA 2/8] Use class to manage BFD reference counts
  - From: Tom Tromey
- [pushed] gdb: Constify solib_find (Re: [RFA 2/8] Use class to manage BFD reference counts)
  - From: Pedro Alves

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]