This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
On 2016-12-05 17:34, Luis Machado wrote:
On 12/05/2016 04:32 PM, Simon Marchi wrote:In the case where we switch to a non-running inferior, we do a"find_inferior_id (num)", although we did the same call right before. We cansafely remove it. gdb/ChangeLog: * inferior.c (inferior_command): Remove duplicate find_inferior_id call. --- gdb/inferior.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/gdb/inferior.c b/gdb/inferior.c index 0abd2c058e..9fcdbd3b83 100644 --- a/gdb/inferior.c +++ b/gdb/inferior.c @@ -763,9 +763,6 @@ inferior_command (char *args, int from_tty) } else { - struct inferior *inf; - - inf = find_inferior_id (num); set_current_inferior (inf); switch_to_thread (null_ptid); set_current_program_space (inf->pspace);Looks fairly obvious.
Yeah, I wasn't sure if that would fall under the obvious rule. Sometimes, things that look obvious like that can end up being wrong. But in this case I really don't see how it could happen. Oh well, I decided to be wild and push it, we'll see. :)
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |