This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 21/22] Class-ify ui_out

On 2016-11-30 07:46, Pedro Alves wrote:

On 11/24/2016 07:18 PM, Simon Marchi wrote:


-/* Create a ui_out object */
+class ui_out_level
+{
+ public:

-extern ui_out *ui_out_new (ui_out_impl_base *impl, int flags = 0);
+  ui_out_level (ui_out_type type)
+  : m_field_count (0),
+    m_type (type)
+  {
+  }
+
+  ui_out_type
+  type (void) const


Just a reminder: "explicit" and "(void)" in multiple places.


Thanks, they are already fixed but it's good to double check.
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]