This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Prevent turning record on while threads are running (PR 20869)

From: Pedro Alves <palves at redhat dot com>
To: Luis Machado <lgustavo at codesourcery dot com>, Simon Marchi <simon dot marchi at ericsson dot com>, gdb-patches at sourceware dot org
Cc: markus dot t dot metzger at intel dot com
Date: Wed, 30 Nov 2016 15:36:46 +0000
Subject: Re: [PATCH] Prevent turning record on while threads are running (PR 20869)
Authentication-results: sourceware.org; auth=none
References: <20161129150758.29912-1-simon.marchi@ericsson.com> <fef2bdd4-d5c8-14a8-73ed-329b27961f1b@codesourcery.com> <8b198908-9a78-d2e8-1726-a471d3afb9b7@ericsson.com> <b9d5bbc8-3656-d680-e1ae-0e2e342e1437@codesourcery.com>

On 11/29/2016 04:47 PM, Luis Machado wrote:
> On 11/29/2016 10:42 AM, Simon Marchi wrote:
>> On 16-11-29 10:58 AM, Luis Machado wrote:
>>>> +if ![supports_reverse] {
>>>
>>> Add an explicit untested call here?
>>
>> Right, adding:
>>
>> untested "reverse debugging not supported"

Shouldn't it be "unsupported" ?

> The above looks good to me.

Agreed.

Thanks,
Pedro Alves

Follow-Ups:
- Re: [PATCH] Prevent turning record on while threads are running (PR 20869)
  - From: Luis Machado

References:
- [PATCH] Prevent turning record on while threads are running (PR 20869)
  - From: Simon Marchi
- Re: [PATCH] Prevent turning record on while threads are running (PR 20869)
  - From: Luis Machado
- Re: [PATCH] Prevent turning record on while threads are running (PR 20869)
  - From: Simon Marchi
- Re: [PATCH] Prevent turning record on while threads are running (PR 20869)
  - From: Luis Machado

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]