This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v2 0/8] Fix gdb's testsuite test names


On 11/28/2016 12:57 PM, Sergio Durigan Junior wrote:
On Friday, November 25 2016, Luis Machado wrote:

Changes in v2:

* Patch 1/8 in v1 is now patch 8/8 in v2, due to organization issues. Patch 8/8
  does a few additional things in v2. Patches 2~8 in v1 are now 1~7 in v2.

Patch 1/8 and Patch 2/8
=========

* Fixed spurious whitespaces.

Patch 8/8
=========

* Updated compilation failure message and replaced existing ones to keep them
  standard.

All other patches have no meaningful changes.

v1 can be found here: https://sourceware.org/ml/gdb-patches/2016-11/msg00813.html

---

I was going to go with a single patch for this, but i kept hitting other
cases where i needed to adjust the regular expressions and substitution rules.

I then decided to have a series with each individual piece that should make it
easier to review as well. The changes are all pretty mechanical, but it would
be nice to have another pair of eyes looking at these to make sure nothing
incorrect got through.

The first patch handles the "testfile as test name" problem. The rest of the
series handles test names starting with uppercase.

Thanks for the patch, Luis!  It would be awesome to also have unique
names for each testcase, but I realize this is a much more difficult
task :-).

I have a few ideas and i may submit a RFC to discuss improvements on this soon.


Just a heads up for everyone: when this patch series is pushed, we are
probably going to see a lot of known XFAILs return on the BuildBot
reports.  This is due to the way we identify the XFAILs, using their
whole name in a case-sensitive manner.

The new XFAILs will be detected during the weekend, when the racy tests
run.

Thanks,


Nothing like breaking a lot of tests for a change! :-P

Thanks for the heads up.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]