This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v2 1/4] gdb: Add tdesc_find_register functions



On Sat, 26 Nov 2016, Mike Frysinger wrote:

On 27 Nov 2016 15:16, Stafford Horne wrote:
+/* Search FEATURE for a register REGNO and return its name. */

GNU style puts two spaces after periods

Understood, sorry I didnt notice it it will be fixed in the next patch version.

+char *
+tdesc_find_register_name (const struct tdesc_feature *feature,
+			   int regno)
+char *
+tdesc_find_register_group_name (const struct tdesc_feature *feature,
+			   int regno)

seems like return values for both of these should be const

Yes, of course, this will also be fixed.

I will check against the other patches too for any similar issues.

FYI, that patches to or1k-tdep.c have detailed function comments which dont seem to match the GNU style, any comment on that?

-Stafford


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]