This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 0/8] Fix gdb's testsuite test names


On 11/25/2016 11:31 AM, Simon Marchi wrote:
On 2016-11-25 12:08, Luis Machado wrote:
I was going to go with a single patch for this, but i kept hitting other
cases where i needed to adjust the regular expressions and
substitution rules.

I then decided to have a series with each individual piece that should
make it
easier to review as well. The changes are all pretty mechanical, but
it would
be nice to have another pair of eyes looking at these to make sure
nothing
incorrect got through.

The first patch handles the "testfile as test name" problem. The rest
of the
series handles test names starting with uppercase.

Luis Machado (8):
  Fixup testcases outputting own name as a test name
  Fix test names starting with uppercase output by basic functions
  Fix test names starting with uppercase using gdb_test on a single
    line.
  Fix test names starting with uppercase using gdb_test_no_output
  Fix test names starting with uppercase using gdb_test_multiple
  Fix test names starting with uppercase using multi-line
    gdb_test/mi_gdb_test
  Fix test names starting with uppercase using multi-line
    gdb_test_no_output
  Fix test names starting with uppercase using multi-line
    gdb_test_multiple

Hi Luis,

I'll take a quick look at those.  While applying, git gave me these
warnings.  It's probably extraneous spaces that were there before, but
if you feel like it you can remove them.


Applying: Fix test names starting with uppercase output by basic functions
.git/rebase-apply/patch:3302: trailing whitespace.
    pass "thread command"
warning: 1 line adds whitespace errors.

Applying: Fix test names starting with uppercase using gdb_test on a
single line.
.git/rebase-apply/patch:1325: trailing whitespace.
gdb_test "print r" " = -1" "test cos(pi) is equal to -1"
.git/rebase-apply/patch:1477: trailing whitespace.
gdb_test "set print test-enum-param three" "Undefined item: \"three\".*"
"set invalid enum parameter"
warning: 2 lines add whitespace errors.

Simon

Thanks. Sure, i'll patch those up.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]