This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [RFA 08/13] Use gdbpy_ref in python.c

From: Pedro Alves <palves at redhat dot com>
To: Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
Date: Tue, 22 Nov 2016 17:21:30 +0000
Subject: Re: [RFA 08/13] Use gdbpy_ref in python.c
Authentication-results: sourceware.org; auth=none
References: <1479674496-14000-1-git-send-email-tom@tromey.com> <1479674496-14000-9-git-send-email-tom@tromey.com>

On 11/20/2016 08:41 PM, Tom Tromey wrote:
> This changes more places in python.c to use gdbpy_ref.
> 
> Additionally, previously gdbpy_apply_type_printers would return
> EXT_LANG_RC_ERROR if a type printer returned None.  However, that
> doesn't seem correct to me; this patch changes it to return
> EXT_LANG_RC_NOP in this case.

Agreed, this is what the value printers do, AFAICT from
gdbpy_apply_val_pretty_printer.

Does that result in user/script-visible behavior?  Should
this be covered by some test?

Anyway, LGTM.

Thanks,
Pedro Alves

Follow-Ups:
- Re: [RFA 08/13] Use gdbpy_ref in python.c
  - From: Tom Tromey

References:
- [RFA 00/13] series #4 of c++ in python
  - From: Tom Tromey
- [RFA 08/13] Use gdbpy_ref in python.c
  - From: Tom Tromey

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]