Re: [PATCH 02/23] Fix spelling mistakes in comments in C source files (gdb)

[Yao Qi <qiyaoltc at gmail dot com>]

On Sun, Nov 20, 2016 at 06:37:57PM +0100, Ambrogino Modigliani wrote:
> gdb/ChangeLog:
> 
>         * gdb/ada-lang.c: Fix spelling in comments.

The file name refers to the file location relative to the ChangeLog
file, so don't need "gdb/".

	* ada-lang.c: Fix spelling in comments.

> 
> gdb/gdbserver/ChangeLog:
> 
>         * gdb/gdbserver/event-loop.c: Fix spelling in comments.

Likewise, drop "gdb/gdbserver/".

>         * gdb/gdbserver/linux-aarch64-low.c: Fix spelling in comments.
>         * gdb/gdbserver/linux-arm-low.c: Fix spelling in comments.
>         * gdb/gdbserver/linux-low.c: Fix spelling in comments.
>         * gdb/gdbserver/linux-ppc-low.c: Fix spelling in comments.
>         * gdb/gdbserver/nto-low.c: Fix spelling in comments.
>         * gdb/gdbserver/server.c: Fix spelling in comments.
>         * gdb/gdbserver/server.h: Fix spelling in comments.
>         * gdb/gdbserver/tracepoint.c: Fix spelling in comments.
>         * gdb/gdbserver/win32-low.c: Fix spelling in comments.
> 
> gdb/testsuite/ChangeLog:
> 
>         * gdb/testsuite/gdb.base/d10vovly.c: Fix spelling in comments.

drop "gdb/testsuite/".

>         * gdb/testsuite/gdb.base/m32rovly.c: Fix spelling in comments.
>         * gdb/testsuite/gdb.base/ovlymgr.c: Fix spelling in comments.
>         * gdb/testsuite/gdb.base/scope0.c: Fix spelling in comments.
>         * gdb/testsuite/gdb.base/sigrepeat.c: Fix spelling in comments.
>         * gdb/testsuite/lib/compiler.c: Fix spelling in comments.
>         * gdb/testsuite/lib/compiler.cc: Fix spelling in comments.

> diff --git a/gdb/s390-linux-tdep.c b/gdb/s390-linux-tdep.c
> index 885aadd..ecd1647 100644
> @@ -7253,7 +7253,7 @@ ex:
>                /* op3c */
>                if (record_full_arch_list_add_reg (regcache, S390_R0_REGNUM + inib[3]))
>                  return -1;
> -              /* fallthru */
> +              /* fall through */

fallthru is an annotate to the source to suppress the warnings from
compiler or other static analysis tools.  I don't know we need to "fix"
them.

Otherwise, the patch is good to me.  Please remove these "fallthru"
replacement in your patch, and send it again.  It can be merged.

Ambrogino doesn't have FSF copyright assignment, but I don't think
it is required in this case, because IMO, this patch is not a
"legally significant change"
https://www.gnu.org/prep/maintain/html_node/Legally-Significant.html
and it can be regarded as "tiny change", although the patch is
not tiny, and the url above doesn't explicitly mention "fixing typo"
is not legally significant change.

-- 
Yao (齐尧)