This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 2/4] Remove code that checks for GNU/non-GNU make

From: Eli Zaretskii <eliz at gnu dot org>
To: Simon Marchi <simon dot marchi at ericsson dot com>
Cc: gdb-patches at sourceware dot org
Date: Wed, 16 Nov 2016 18:32:24 +0200
Subject: Re: [PATCH 2/4] Remove code that checks for GNU/non-GNU make
Authentication-results: sourceware.org; auth=none
References: <20161116160808.12830-1-simon.marchi@ericsson.com> <20161116160808.12830-3-simon.marchi@ericsson.com>
Reply-to: Eli Zaretskii <eliz at gnu dot org>

> From: Simon Marchi <simon.marchi@ericsson.com>
> CC: Simon Marchi <simon.marchi@polymtl.ca>
> Date: Wed, 16 Nov 2016 11:08:06 -0500
> 
> From: Simon Marchi <simon.marchi@polymtl.ca>
> 
> Since GNU make is now required to build GDB, we can remove everything
> that checks whether the current make implemention is the GNU one or
> not.  I simply removed the @GMAKE_TRUE@ prefixes and removed the whole
> lines that were prefixed with @GMAKE_FALSE@.

Since GDB is built by first running Make in sibling directories, which
don't require a GNU Make yet, what does this mean in case the user
runs a non-GNU Make?  Will they have strange errors half way through
the build?  Should we detect this early on and bail out?

Follow-Ups:
- Re: [PATCH 2/4] Remove code that checks for GNU/non-GNU make
  - From: Andreas Schwab

References:
- [PATCH 0/4] Require GNU make
  - From: Simon Marchi
- [PATCH 2/4] Remove code that checks for GNU/non-GNU make
  - From: Simon Marchi

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]