This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [RFA 01/20] Introduce gdbpy_enter

From: Pedro Alves <palves at redhat dot com>
To: Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
Date: Thu, 10 Nov 2016 23:18:56 +0000
Subject: Re: [RFA 01/20] Introduce gdbpy_enter
Authentication-results: sourceware.org; auth=none
References: <1478816387-27064-1-git-send-email-tom@tromey.com> <1478816387-27064-2-git-send-email-tom@tromey.com>

LGTM with a nit below.

On 11/10/2016 10:19 PM, Tom Tromey wrote:
> +
> + private:
> +
> +  // Intentionally not defined.

Use /**/ comments.

But actually, since we require C++11 now, use =delete instead.

> +  gdbpy_enter (const gdbpy_enter &);
> +  gdbpy_enter &operator= (const gdbpy_enter &);

Thanks,
Pedro Alves

References:
- [RFA 00/20] more use of C++ in the Python layer
  - From: Tom Tromey
- [RFA 01/20] Introduce gdbpy_enter
  - From: Tom Tromey

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]