Re: [PATCH] gdbarch: Use an anonymous union for target data in `gdbarch_info'

[Simon Marchi <simon dot marchi at polymtl dot ca>]

On 2016-10-18 12:19, Maciej W. Rozycki wrote:
> As an update to commit ede5f15146ae ("gdbarch.h: Change
> gdbarch_info::tdep_info's type to void *") replace the definition of 
> the
> `tdep_info' member in `struct gdbarch_info' with an anonymous union,
> comprising the original member, with its type reverted to `struct
> gdbarch_tdep_info *', a `tdesc_data' member of a `struct 
> tdesc_arch_data
> *' type and an `id' member of an `int *' type.  Remove now unnecessary
> casts throughout use places then, making code easier to read an less
> prone to errors, which may happen with casting.

I glanced quickly at your patch, and I think it looks good.  As Yao 
said, some comments would be nice, because just like that it's hard to 
understand why those fields are grouped together in an union, as they 
seem unrelated to each other.