This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [rfc] PR 20569, segv in follow_exec

From: Luis Machado <lgustavo at codesourcery dot com>
To: Pedro Alves <palves at redhat dot com>, Sandra Loosemore <sandra at codesourcery dot com>, <gdb-patches at sourceware dot org>
Date: Wed, 19 Oct 2016 11:14:45 -0500
Subject: Re: [rfc] PR 20569, segv in follow_exec
Authentication-results: sourceware.org; auth=none
References: <57F6D57D.8070603@codesourcery.com> <50f4c7d8-44e3-4351-0b54-9cbaef64717a@codesourcery.com> <14a10c11-cda1-945c-560a-ee619fe59101@redhat.com>
Reply-to: Luis Machado <lgustavo at codesourcery dot com>

On 10/19/2016 08:37 AM, Pedro Alves wrote:

On 10/18/2016 07:11 PM, Luis Machado wrote:

I went through the patch and, although this code as a whole is a bit on
the convoluted side, it looks reasonable to me.

Segfaults are not supposed to happen, so allowing the session to
continue is a good thing IMO.

Sounds like a good candidate for master and even stable branches.


I didn't look at the patch in detail yet, but I think it'd be
very good to have tests?

Thanks,
Pedro Alves

I fixed a gotcha with the patch and i have a reproducer that makes GDBcrash on x86-64. I'll craft a test.

Follow-Ups:
- Re: [rfc] PR 20569, segv in follow_exec
  - From: Luis Machado

References:
- [rfc] PR 20569, segv in follow_exec
  - From: Sandra Loosemore
- Re: [rfc] PR 20569, segv in follow_exec
  - From: Luis Machado
- Re: [rfc] PR 20569, segv in follow_exec
  - From: Pedro Alves

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]