This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Fix -trace-save crash when argument is missing
- From: Yao Qi <qiyaoltc at gmail dot com>
- To: Simon Marchi <simon dot marchi at ericsson dot com>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Mon, 17 Oct 2016 16:08:50 -0400
- Subject: Re: [PATCH] Fix -trace-save crash when argument is missing
- Authentication-results: sourceware.org; auth=none
- References: <20161014202536.21670-1-simon.marchi@ericsson.com>
HI Simon,
Patch is good to me. A nit below,
On Fri, Oct 14, 2016 at 4:25 PM, Simon Marchi <simon.marchi@ericsson.com> wrote:
> +
> + if (oind >= argc)
Nit: if (argc - oind != 1)
> + error (_("Argument required (file in which to save trace data)"));
> +
> filename = argv[oind];
>
--
Yao (齐尧)