This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA 16/22] Use std::vector in elf_read_minimal_symbols
- From: Pedro Alves <palves at redhat dot com>
- To: Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
- Date: Sun, 9 Oct 2016 18:30:01 +0100
- Subject: Re: [RFA 16/22] Use std::vector in elf_read_minimal_symbols
- Authentication-results: sourceware.org; auth=none
- References: <1474949330-4307-1-git-send-email-tom@tromey.com> <1474949330-4307-17-git-send-email-tom@tromey.com>
On 09/27/2016 05:08 AM, Tom Tromey wrote:
> This changes elf_read_minimal_symbols to use std::vector rather than
> an explicit allocation. This removes a cleanup.
LGTM, though same comment about unique_ptr applies. (I'll stop
saying that in follow up patches, even it would apply).
Thanks,
Pedro Alves