This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA 07/22] Change scoped_minimal_symbol_reader to store objfile
- From: Tom Tromey <tom at tromey dot com>
- To: Trevor Saunders <tbsaunde at tbsaunde dot org>
- Cc: Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
- Date: Fri, 30 Sep 2016 15:40:20 -0600
- Subject: Re: [RFA 07/22] Change scoped_minimal_symbol_reader to store objfile
- Authentication-results: sourceware.org; auth=none
- References: <1474949330-4307-1-git-send-email-tom@tromey.com> <1474949330-4307-8-git-send-email-tom@tromey.com> <20160929090743.4i44bg6egfflvkbe@ball>
>>>>> "Trevor" == Trevor Saunders <tbsaunde@tbsaunde.org> writes:
>> Currently, minimal symbol table creation is not reentrant; it
>> relies on global (static) variables in minsyms.c. */
>>
>> - explicit scoped_minimal_symbol_reader ();
>> + explicit scoped_minimal_symbol_reader (struct objfile *);
Trevor> C++ doesn't require the explicit struct / union when refering to the
Trevor> type, though of course you can keep them if you think it makes something
Trevor> clearer.
I kept it just because "struct objfile" is used everywhere else in gdb.
>> @@ -79,6 +79,8 @@ class scoped_minimal_symbol_reader
>> scoped_minimal_symbol_reader &operator=
>> (const scoped_minimal_symbol_reader &);
>> scoped_minimal_symbol_reader (const scoped_minimal_symbol_reader &);
>> +
>> + struct objfile *objfile;
Trevor> fwiw gcc convention is to prefix members with m_, so doing so in gdb as
Trevor> well would be nice.
I made this change.
Tom