This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [RFA 01/22] Change selttest.c to use use std::vector

From: Simon Marchi <simon dot marchi at polymtl dot ca>
To: Tom Tromey <tom at tromey dot com>
Cc: gdb-patches at sourceware dot org
Date: Fri, 30 Sep 2016 10:38:23 -0400
Subject: Re: [RFA 01/22] Change selttest.c to use use std::vector
Authentication-results: sourceware.org; auth=none
References: <1474949330-4307-1-git-send-email-tom@tromey.com> <1474949330-4307-2-git-send-email-tom@tromey.com>

On 2016-09-27 00:08, Tom Tromey wrote:

-  printf_filtered (_("Ran %u unit tests, %d failed\n"),
-		   VEC_length (self_test_function_ptr, tests), failed);
+  printf_filtered (_("Ran %lu unit tests, %d failed\n"),
+		   tests.size (), failed);


This doesn't build on 32 bits:

selftest.c: In function ‘void run_self_tests()’:

selftest.c:62:27: error: format ‘%lu’ expects argument of type ‘longunsigned int’, but argument 2 has type ‘std::vector<void(*)()>::size_type {aka unsigned int}’ [-Werror=format=]

      tests.size (), failed);
                           ^
I think the right format size specifier would be 'z'.

Follow-Ups:
- Re: [RFA 01/22] Change selttest.c to use use std::vector
  - From: Tom Tromey

References:
- [RFA 00/22] More C++-ification
  - From: Tom Tromey
- [RFA 01/22] Change selttest.c to use use std::vector
  - From: Tom Tromey

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]