This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] gdb: Use std::max and std::min throughout
On 09/19/2016 02:44 PM, Pedro Alves wrote:
> On 09/19/2016 02:35 PM, Pedro Alves wrote:
>> # define gettext(Msgid) (Msgid)
>> # define dgettext(Domainname, Msgid) (Msgid)
>> # define dcgettext(Domainname, Msgid, Category) (Msgid)
>> # define textdomain(Domainname) while (0) /* nothing */
>> # define bindtextdomain(Domainname, Dirname) while (0) /* nothing */
>> # define _(String) (String)
>> # define N_(String) (String)
>> #endif
>
> Alternatively, simply remove the troublesome *gettext and *textdomain
> macros, leaving only the _ and N_ ones. I can't seem to find any
> directly reference to gettext in the tree. The textdomain calls
> in main.c would need to be wrapped in #ifdef ENABLE_NLS, but
> likes like that is all.
>
> I don't have a strong preference either way.
>
Seems like gas/asintl.h handles this in yet another way [1].
That one seems too much of a hack to me, though.
[1] - and ld/ld.h too, see git show a70c2403.
Thanks,
Pedro Alves