This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 0/6] S390: Watchpoint enhancements and hardware breakpoints
- From: Andreas Arnez <arnez at linux dot vnet dot ibm dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: Ulrich Weigand <uweigand at de dot ibm dot com>, gdb-patches at sourceware dot org
- Date: Fri, 16 Sep 2016 19:28:33 +0200
- Subject: Re: [PATCH 0/6] S390: Watchpoint enhancements and hardware breakpoints
- Authentication-results: sourceware.org; auth=none
- References: <20160916124323.AE052FE999@oc8523832656.ibm.com> <c0d0de65-429d-7449-7f98-f8aefb1058e7@redhat.com>
On Fri, Sep 16 2016, Pedro Alves wrote:
> I see. Thanks for the clarification.
>
> A comment to the effect in the code would be nice. Maybe it's
> there and I missed it.
OK, changed the relevant comment to this:
/* Don't install hardware breakpoints while single-stepping, since
our PER settings (e.g. the nullification bit) might then conflict
with the kernel's. But re-install them afterwards. */
Also changed the documentation of lwp_is_stepping as suggested by Yao:
/* Return nonzero if we are single-stepping this LWP at the ptrace
level. */
> I have no further comments on the series. LGTM.
Thanks. Pushed with the changes above.
--
Andreas