This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] [GDBserver] Replace "reinsert_breakpoint" with "singlestep_breakpoint"

On 09/02/2016 09:04 AM, Yao Qi wrote:

> Sure.  Let us use "single_step" in code and "single-step" in comments.
> How about the patch below?
> 

Great, LGTM.

On 09/02/2016 09:04 AM, Yao Qi wrote:
> --- a/gdb/gdbserver/mem-break.c
> +++ b/gdb/gdbserver/mem-break.c
> @@ -134,7 +134,7 @@ enum bkpt_type
>      gdb_breakpoint_Z4,
>  
>      /* A basic-software-single-step breakpoint.  */
> -    reinsert_breakpoint,
> +    single_step_breakpoint,

Can you drop the "basic" while at it?  Made some sense
when this was only used for the return address of 
nptl's magic thread event breakpoint functions, but it no
longer does.

Thanks,
Pedro Alves
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]