This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA 0/6] Add -Wunused-but-set-parameter and -Wunused-but-set-variable
- From: Yao Qi <qiyaoltc at gmail dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: Tom Tromey <tom at tromey dot com>, "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Thu, 21 Jul 2016 12:10:37 +0100
- Subject: Re: [RFA 0/6] Add -Wunused-but-set-parameter and -Wunused-but-set-variable
- Authentication-results: sourceware.org; auth=none
- References: <1465248812-23902-1-git-send-email-tom@tromey.com> <CAH=s-POD0ONLxHsoMFooOibZ58TB_UjW85GXioaM5_koQ2FBCA@mail.gmail.com> <6a954e1a-ed72-fc02-b9b6-cce85e9b58e9@redhat.com>
On Thu, Jul 21, 2016 at 11:38 AM, Pedro Alves <palves@redhat.com> wrote:
> On 06/28/2016 04:02 PM, Yao Qi wrote:
>> On Mon, Jun 6, 2016 at 10:33 PM, Tom Tromey <tom@tromey.com> wrote:
>>> I built and regression tested this using --enable-targets=all on
>>> x86-64 Fedora 23. However, I could not update the various nat-*
>>> files, so there are probably unfixed warnings lurking there.
>>
>> Can you use cross compiler to cross build native gdb to catch these warnings?
>> otherwise, once this patch series go in, gdb build on host other than linux may
>> be broken.
>
> The worse that can happen is a warning becomes a build error
> due to -Werror. Since people can always use --disable-werror
> to work around it, and that is enabled by default in releases, I
> don't think a temporary -Werror build break on master is a major
> problem.
>
> What would you say would be a sufficient set of hosts to test before
> enabling a warning?
>
> Testing all supported hosts and all architectures would be unfeasible,
> naturally.
That isn't what I meant. We need to cover the hosts we are able to, like
mingw, and unix machine we can access in gcc compile farm.
>
> I'd think it'd be acceptable to just build on a couple of the
> more common hosts, in the name of forward progress.
>
Yes, I agree.
--
Yao (齐尧)