This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA 2/3] Move filename extensions into language_defn
- From: Tom Tromey <tom at tromey dot com>
- To: Yao Qi <qiyaoltc at gmail dot com>
- Cc: Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
- Date: Mon, 06 Jun 2016 15:04:31 -0600
- Subject: Re: [RFA 2/3] Move filename extensions into language_defn
- Authentication-results: sourceware.org; auth=none
- References: <1465051760-25840-1-git-send-email-tom at tromey dot com> <1465051760-25840-3-git-send-email-tom at tromey dot com> <86r3cawix0 dot fsf at gmail dot com>
>>>>> "Yao" == Yao Qi <qiyaoltc@gmail.com> writes:
Yao> Tom Tromey <tom@tromey.com> writes:
>> This moves filename extensions from a function in symfile.c out to
>> each language_defn. I think this is an improvement because it means
>> less digging around when writing a new language port.
Yao> Patch is good to me. Note that we can improve it further by moving
Yao> language related stuff out of symfile.c to language.c. Then, we can
Yao> remove filename_language_table in symfile.c, and use array languages in
Yao> language.c as a replacement.
I considered this, but users can add their own mappings. So, we would
still need both tables. It wouldn't result in a net code removal.
If you want, though, I can still do this.
Tom